The immediate effects are clearly favourable. An increase in demand shifts the curve right, and the market settles at both a higher price and a larger quantity. Firms therefore sell more units and receive more for each one, so total revenue rises on both counts — a rare combination, since most changes that raise one reduce the other. Higher revenue usually means higher profit, and selling a larger output may let firms spread their fixed costs over more units, lowering the average cost of each. Rising demand also makes investment and expansion easier to justify and to finance.
But several things can turn this against the firms already in the market. The clearest is entry. Profitable, expanding markets attract new firms, and their arrival shifts the market supply curve right, which pushes the price back down and takes share from the incumbents. An established firm can easily end up with a lower price and a smaller share than before the demand increase, and in a market that is easy to enter this is the normal outcome rather than an unlucky one.
Meeting the extra demand also has costs. Producing more may require overtime, hiring in a tighter labour market, or bringing less efficient capacity into use, all of which raise the cost per unit — so higher revenue does not automatically mean higher profit. A firm that expands capacity to meet demand that later falls back is left with expensive idle plant, which is how firms that grew fastest in a boom often fail hardest in the downturn.
There is a distributional point too. An increase in demand is good for firms that can supply more, and much less good for those that cannot. Where a firm is at full capacity, or its own supply is inelastic, it captures the higher price but little of the extra quantity, while rivals with spare capacity take the growth. The benefit is not spread evenly across the industry.
My judgement is that an increase in demand is almost always good in the short run and frequently not in the long run, and the variable that decides it is how easily new firms can enter. Where entry is hard — through patents, high set-up costs, strong brands or scarce licences — the incumbents keep most of the gain and the increase is straightforwardly good for them. Where entry is easy, the gain is competed away, and firms may end up no better off than before while having taken on the costs and risks of expanding.
That also explains why firms so often respond to rising demand by trying to raise barriers rather than simply producing more — building brands, securing exclusive supply, lobbying for licensing. They are acting on exactly this logic: the increase in demand is only worth having if it can be kept.